Key elements to check for when doing code reviews

Always take a step back and think about the key elements of code review.

  • Does the code follow your team’s coding guidelines
  • Does the code meet its objective / acceptance criteria.
  • Is the code legible and easy to understand what it’s doing without the need for heavy comments / documentation. (This one for me is one of the most important, as I’m a huge fan of descriptive method and variable names.
  • Does the code need any refactoring, considering security, performance or simply ease of reading.
  • Does the code follow simple design patterns / principles e.g single responsibility, abstraction, encapsulation etc. If not make suggestions on how this can be achieved or perhaps teach those not familiar with it what it means and the benefits. (View Highlight)

Additional Metadata